Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for permissions check for Advanced Workflow #627

Open
wants to merge 1 commit into
base: 3.5
Choose a base branch
from

Conversation

obj63mc
Copy link

@obj63mc obj63mc commented Oct 24, 2020

If you are utilizing the Advanced Workflows module using a simply review and approve process the following happens on all pages except blog posts currently.

  1. Content author creates a 'Page' type page class and requests approval to publish
  2. Admin is notified and must select 'reject' or 'approve', the publish button is hidden. Screen shot below of how page normally looks for the admin -

Screen Shot 2020-10-23 at 11 07 19 AM

Now if we do the same with a blog post

  1. Content Author creates a new 'Blog Post' type page class under a blog, requests approval to publish
  2. Admin is notified and must select 'reject' or 'approve', the publish button is shown but should not be shown due to workflow being active. Screen shot below -

Screen Shot 2020-10-23 at 11 09 19 AM

The cause for this is that the blog posts canPublish function was checking for an administrator account before letting the Advanced Workflow extensions run first. I have changed the order and now this is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant